Code review comment for lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

About OpenERP "standard" of former code we also have import with bad namespace, use of class alias and useless class instanciations.

In OpenERP coding guidelines nothing is clearly said about XML indentation:
https://doc.openerp.com/7.0/contribute/15_guidelines/
As you said, this is defacto

Nevertheless, my opinion is that we shouldn't say "this is a standard" if there are no obvious reasons beside it.

So what will be the community standard we will decide and why?

By the way, readability counts
(Does it also counts on code review in lp?)

« Back to merge proposal