Code review comment for lp:~camptocamp/margin-analysis/7.0-port-product_historical_margin-xml-retab-yvr

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Yannick, thank you very much for the cleaning.

I wonder, because we have never discussed this before, what is the correct space indentation for XML. In Python it is used 4 spaces. I have seen that you have used 2 spaces. I see this a little short, but I would like to know the opinion of others.

Regards.

review: Needs Information (code review, no test)

« Back to merge proposal