Code review comment for lp:~camptocamp/margin-analysis/7.0-fix_1280221-afe

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM, but I wonder if there is any possibility to test the infinite recursion itself, because for now, if we have a future regression, test will enter also in an infinite loop.

Don't you think it's better to propose a patch for _bom_explode that avoid infinite recursion? Or is it a specific problem of this module?

Regards.

review: Needs Information (code review)

« Back to merge proposal