Code review comment for lp:~camptocamp/magentoerpconnect/oerp61-oldstable-import-partners-2012-12-13
Revision history for this message
| Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
l187 if website_id:
I don't think that it is possible to have a website_id which is 0, but if it could be the case we would preferably test if website is not None:
If a website_id could be 0, in that case, website_id is at first a string before we cast it to int.
It could be '0' but not 0
Seems fine to me like that
I will fix the rest ASAP