Code review comment for lp:~camptocamp/hr-timesheet/7.0-fix-1206843-yvr
Revision history for this message
| Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Thanks for the review and tests Stéphane!
It is indead not as clean as I would like it to be.
I think the main issue here is that we are changing the relation of a field so it can leads to modules expecting a behavior the new relation doesn't have. I'm just fixing this here by simulating the missing behavior.
An other option would be some cross module monkey patching to disable unwanted actions. I'm not sure it would be much cleaner nor easy to do.