Code review comment for lp:~camptocamp/hr-timesheet/7.0-fix-1206843-yvr
Revision history for this message
| Stéphane Bidoul (Acsone) (sbi) wrote | # |
review:
Needs Information
(code review and test)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I just made a test on a fresh v7 database with the ocb branches and the latest version of hr-timesheet. I installed timesheet_task, created a project a task and entered some time on the task. Then I renamed the task and everything went fine.
To reproduce the bug, I had to install project_timesheet.
Now, I personally always considered timesheet_task to be incompatible with project_timesheet as they have a fundamentally different approach. Is there a reason to install project_timesheet when one uses timesheet_task, possibly in combination with hr_timesheet_task?
Regarding this MP, it makes me quite uncomfortable to add a dummy field that always return empty value. This can be misleading. That said, I don't immediately see a clean way to make timesheet_task and project_timesheet compatible.