HR - Timesheet Management

Code review comment for lp:~camptocamp/hr-timesheet/7.0-add-hr_timesheet_improvement

  1. 7.0-add-hr_timesheet_improvement
  2. Merge into 7.0
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

In the related fields, as you did not put invalidations, we would have problems when:

 - the date of an analytic line is changed directly from the analytic line
 - the name of an account is changed directly from the account

As a result, the date_aal and name_account in hr.analytic.timesheet would be desynchronized and the sort would be wrong.

l.118: use the constant openerp.tools.DEFAULT_SERVER_DATETIME_FORMAT

l129-131: a poor docstring, he lost his method. Or was it intended? you are cruel with him

« Back to merge proposal