Code review comment for lp:~camptocamp/geospatial-addons/6.1-swiss-topo-zoom-20130111
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
OK, I had misunderstood. It's OK for me to merge, but if you have a couple of hours more, I think there are a couple of weird assumptions made there, and some hardcoded stuff which ought to be handled differently.
I'm especially bothered by the attribute name "swisstopo_type" which look very ad hoc, and not generic enough. I don't know where this attribute is used but:
* it should be renamed to somethingelse_type
* and the information about the available resolutions should be conveyed directly in another place and not hardcoded in the javascript code.