Merge lp:~camptocamp/e-commerce-addons/7.0-sale_payment_method-base_transaction_id into lp:~extra-addons-commiter/e-commerce-addons/7.0
Status: | Rejected |
---|---|
Rejected by: | Guewen Baconnier @ Camptocamp |
Proposed branch: | lp:~camptocamp/e-commerce-addons/7.0-sale_payment_method-base_transaction_id |
Merge into: | lp:~extra-addons-commiter/e-commerce-addons/7.0 |
Diff against target: |
121 lines (+106/-0) 3 files modified
sale_payment_method_transaction_id/__init__.py (+22/-0) sale_payment_method_transaction_id/__openerp__.py (+48/-0) sale_payment_method_transaction_id/sale.py (+36/-0) |
To merge this branch: | bzr merge lp:~camptocamp/e-commerce-addons/7.0-sale_payment_method-base_transaction_id |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joël Grand-Guillaume @ camptocamp | code review, no tests | Approve | |
Review via email: mp+203694@code.launchpad.net |
Commit message
[ADD] sale_payment_
Description of the change
In my pursuit to streamline the usage of transaction ids (from lp:banking-addons/bank-statement-reconcile-7.0) throughout all the chain from a sales order to the reconciliation of invoices, payment and bank statements (see also my other MP [0], I propose this new link module to integrate the sale_payment_module with base_transactio
This module is automatically installed when both modules are installed and it does a simple thing: when a sales order has a transaction id, it is copied to the payment move lines. This will later allow to reconcile the entries with the lines generated by the bank statement.
[0] https:/
https:/
https:/
Unmerged revisions
- 291. By Guewen Baconnier @ Camptocamp
-
[ADD] sale_payment_
method_ transaction_ id: link module between sale_payment_method and base_transaction_id
LGTM, thanks !