Merge lp:~camptocamp/banking-addons/7.0-bank-statement-reconcile-transaction_id-imp into lp:banking-addons/bank-statement-reconcile-70
Status: | Superseded |
---|---|
Proposed branch: | lp:~camptocamp/banking-addons/7.0-bank-statement-reconcile-transaction_id-imp |
Merge into: | lp:banking-addons/bank-statement-reconcile-70 |
Diff against target: |
710 lines (+396/-92) 21 files modified
account_advanced_reconcile_transaction_ref/__init__.py (+0/-1) account_advanced_reconcile_transaction_ref/__openerp__.py (+2/-2) account_advanced_reconcile_transaction_ref/account.py (+0/-54) account_advanced_reconcile_transaction_ref/advanced_reconciliation.py (+24/-1) account_advanced_reconcile_transaction_ref/easy_reconcile.py (+2/-0) account_advanced_reconcile_transaction_ref/easy_reconcile_view.xml (+6/-1) account_easy_reconcile/easy_reconcile.xml (+2/-2) account_payment_transaction_id/__init__.py (+3/-0) account_payment_transaction_id/__openerp__.py (+43/-0) account_payment_transaction_id/account_payment.py (+47/-0) account_statement_transactionid_completion/__openerp__.py (+2/-0) account_statement_transactionid_completion/data.xml (+7/-1) account_statement_transactionid_completion/statement.py (+87/-2) account_statement_transactionid_completion/statement_view.xml (+6/-6) account_statement_transactionid_completion/test/completion_invoice_transactionid_test.yml (+49/-0) account_statement_transactionid_completion/test/completion_transactionid_test.yml (+1/-1) account_statement_transactionid_completion/test/invoice.yml (+30/-0) base_transaction_id/__init__.py (+1/-0) base_transaction_id/account_move.py (+37/-0) base_transaction_id/invoice.py (+17/-3) statement_voucher_killer/voucher.py (+30/-18) |
To merge this branch: | bzr merge lp:~camptocamp/banking-addons/7.0-bank-statement-reconcile-transaction_id-imp |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joël Grand-Guillaume @ camptocamp | code review, no tests | Approve | |
Review via email: mp+202806@code.launchpad.net |
This proposal has been superseded by a proposal from 2014-03-21.
Description of the change
Improvement around the Transaction IDs modules
=======
This proposal aims to improve the modules using transaction ids, I will start by summarizing what are they used for, then what are the existing problems and what changes I propose.
Transaction IDs?
----------------
The transaction IDs are a technical reference for a move line. They are to differentiate from the usual reference that are a reference for humans firstly (more about that here [0]). Usually, the transaction IDs are defined by external systems such as payment gateways and are a way to streamline the reconciliations between the invoices, bank statements...
Changes
-------
1) account_
It makes much sense to add the field in 'base_transacti
So I moved these things from 'account_
2) In account_
3) A consequence of the change 2) is that the automatic reconcile from transaction ref will no longer work for those not using the transaction ids in the bank statement but only the ref. So I added a new reconciliation rule that matches 'ref' vs 'transaction id'. The only drawback is that they will need to change their configuration, but at least the rules will be clear on their intentions.
4) completion rules: 'base_transacti
Thanks for the good job. LGTM