Code review comment for lp:~camptocamp/department-mgmt/add-dep-on-project-task-jge

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Joël,

The MP you have done seems good, but I see a little problem: this modification can give the user a false impression that the department is selected by task, and when they try to change it, they get frustrated, because it's readonly.

I advice to change field label to 'Project department' to avoid this confussion.

Regards.

review: Needs Fixing (code review)

« Back to merge proposal