Code review comment for lp:~camptocamp/department-mgmt/add-account-department-fix-default-anyltic-jge
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
l.21: context propagation is missing
l.25-25: indentation could be aligned
l.37: if the department of the account changes, the analytic lines won't be changed. That's maybe what is wanted though. I propose either to add triggers, either to add a comment why the departement on the analytic lines should not be changed