Banking Addons

Code review comment for lp:~camptocamp/banking-addons/bank-statement-reconcile-7.0-account_easy_reconcile-analytic-account

  1. bank-statement-reconcile-7.0-account_easy_reconcile-analytic-account
  2. Merge into bank-statement-reconcile-70
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Hello Pedro, I don't see either how it could return browse_null.

IMO, we could even simply write

'analytic_account_id': rec_method.analytic_account_id.id,

As if rec_method.analytic_account_id is browse_null
rec_method.analytic_account_id.id would return False

But LGTM like this.

review: Approve (code review, no test)

« Back to merge proposal