Merge lp:~camptocamp/banking-addons/already_delete_reconcile_id_resubmit into lp:banking-addons/bank-statement-reconcile-70

[Vincent Renaville@camptocamp]

[FIX] remove account.reconcile before deleting a account.move

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I think a more efficient and straightforward way would be something along those lines:

    [...]
    reconcile_obj = self.pool.get('account.move.reconcile')
    reconcile_ids = set()
    for move_line in move.line_id:
        if move_line.reconcile_id:
            reconcile_ids.add(move_line.reconcile_id.id)
    reconcile_obj.unlink(cr, uid, list(reconcile_ids), context=context)
    return [...]

So you'll do only 1 DELETE at the end of the loop.

review: Needs Fixing

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

@Vincent, any update here please ?

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

LGTM

review: Approve (code review, no tests)

[Omar (Pexego) (omar7r)]

PEP8 compliant, please, spaces after comma.

Thanks

review: Needs Fixing (code review)

[Leonardo Pistone (lepistone)]

There are some tabs that should be spaces. With that and the commas fixed, I approve.

Thanks Vincent!

review: Needs Fixing (code review)

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

You're right, I miss those ones...

review: Needs Fixing (code review, no tests)

[lp:~camptocamp/banking-addons/already_delete_reconcile_id_resubmit]

103. By Vincent Renaville@camptocamp on 2013-12-13

[FIX] PEP8

[Vincent Renaville@camptocamp (vrenaville-c2c)]

Hello,

Thanks for the review !
PEP8 seems to be ok now.

Vincent

[Leonardo Pistone (lepistone)]

Thanks Vincent!

review: Approve

[Omar (Pexego) (omar7r)]

Approved now, thanks

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks!

review: Approve (code review)

=== modified file 'account_statement_ext/account.py'
--- account_statement_ext/account.py	2012-12-20 13:37:01 +0000
+++ account_statement_ext/account.py	2013-12-13 14:07:06 +0000
@@ -31,8 +31,11 @@
         Delete the reconciliation when we delete the moves. This
         allow an easier way of cancelling the bank statement.
         """
+        reconcile_to_delete = []
+        reconcile_obj = self.pool.get('account.move.reconcile')
         for move in self.browse(cr, uid, ids, context=context):
             for move_line in move.line_id:
                 if move_line.reconcile_id:
-                    move_line.reconcile_id.unlink(context=context)
+                    reconcile_to_delete.append(move_line.reconcile_id.id)
+        reconcile_obj.unlink(cr, uid, reconcile_to_delete, context=context)
         return super(account_move, self).unlink(cr, uid, ids, context=context)