Merge lp:~camptocamp/banking-addons/already_delete_reconcile_id into lp:banking-addons/bank-statement-reconcile-70

[Vincent Renaville@camptocamp]

[FIX] prevent to delete an already deleted reconcile_id

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I think a more efficient and straightforward way would be something along those lines:

    [...]
    reconcile_obj = self.pool.get('account.move.reconcile')
    reconcile_ids = set()
    for move_line in move.line_id:
        if move_line.reconcile_id:
            reconcile_ids.add(move_line.reconcile_id.id)
    reconcile_obj.unlink(cr, uid, list(reconcile_ids), context=context)
    return [...]

So you'll do only 1 DELETE at the end of the loop.

review: Needs Fixing

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

@Vincent, any update here please ?

Unmerged revisions

95. By Vincent Renaville@camptocamp on 2013-07-26

[FIX] prevent to delete an already deleted reconcile_id

=== modified file 'account_statement_ext/account.py'
--- account_statement_ext/account.py	2012-12-20 13:37:01 +0000
+++ account_statement_ext/account.py	2013-07-26 13:44:24 +0000
@@ -31,8 +31,12 @@
         Delete the reconciliation when we delete the moves. This
         allow an easier way of cancelling the bank statement.
         """
+        all_ready_delete = []
         for move in self.browse(cr, uid, ids, context=context):
             for move_line in move.line_id:
                 if move_line.reconcile_id:
-                    move_line.reconcile_id.unlink(context=context)
+                    ## We check if the reconcile is still there
+                    if move_line.reconcile_id.id not in all_ready_delete:
+                        all_ready_delete.append(move_line.reconcile_id.id)
+                        move_line.reconcile_id.unlink(context=context)
         return super(account_move, self).unlink(cr, uid, ids, context=context)