Merge lp:~camptocamp/banking-addons/6.1-account_easy_reconcile-extract-dependency into lp:banking-addons/bank-statement-reconcile-61

Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Merge reported by: Joël Grand-Guillaume @ camptocamp
Merged at revision: not available
Proposed branch: lp:~camptocamp/banking-addons/6.1-account_easy_reconcile-extract-dependency
Merge into: lp:banking-addons/bank-statement-reconcile-61
Diff against target: 138 lines (+24/-38)
4 files modified
account_easy_reconcile/__openerp__.py (+23/-15)
account_easy_reconcile/easy_reconcile.py (+0/-8)
account_easy_reconcile/easy_reconcile.xml (+0/-14)
account_easy_reconcile/i18n/fr.po (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/banking-addons/6.1-account_easy_reconcile-extract-dependency
Reviewer Review Type Date Requested Status
Joël Grand-Guillaume @ camptocamp Approve
Review via email: mp+140873@code.launchpad.net

This proposal supersedes a proposal from 2012-12-18.

Commit message

[FIX] remove the dependency on base_scheduler_creator and fix manifest's description

Description of the change

 * update the manifest description because account_advanced_reconcile is no longer in c2c-financial-addons

 * remove the dependency on base_scheduler_creator because it:
   - does not work on the web client
   - is not essential to use the addon (it would need to be put in a glue module, if it was working)
   - complicate the installation of the addon as it is not in the same branch

To post a comment you must log in.
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

LGTM

Thanks !

review: Approve
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote : Posted in a previous version of this proposal

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_easy_reconcile/__openerp__.py'
--- account_easy_reconcile/__openerp__.py 2012-12-20 09:42:44 +0000
+++ account_easy_reconcile/__openerp__.py 2012-12-20 11:11:30 +0000
@@ -22,27 +22,35 @@
22{22{
23 "name" : "Easy Reconcile",23 "name" : "Easy Reconcile",
24 "version" : "1.1",24 "version" : "1.1",
25 "depends" : ["account", "base_scheduler_creator"25 "depends" : ["account",
26 ],26 ],
27 "author" : "Akretion,Camptocamp",27 "author" : "Akretion,Camptocamp",
28 "description": """28 "description": """
29This is a shared work between Akretion and Camptocamp in order to provide:29Easy Reconcile
30==============
31
32This is a shared work between Akretion and Camptocamp
33in order to provide:
30 - reconciliation facilities for big volume of transactions34 - reconciliation facilities for big volume of transactions
31 - setup different profiles of reconciliation by account35 - setup different profiles of reconciliation by account
32 - each profile can use many methods of reconciliation36 - each profile can use many methods of reconciliation
33 - this module is also a base to create others reconciliation methods37 - this module is also a base to create others
34 which can plug in the profiles38 reconciliation methods which can plug in the profiles
35 - a profile a reconciliation can be run manually or by a cron39 - a profile a reconciliation can be run manually
36 - monitoring of reconciliation runs with an history which keep track40 or by a cron
37 of the reconciled entries41 - monitoring of reconciliation runs with an history
3842 which keep track of the reconciled entries
392 simple reconciliation methods are integrated in this module, the simple43
40reconciliations works on 2 lines (1 debit / 1 credit) and do not allows442 simple reconciliation methods are integrated
41partial reconcilation, they also match on 1 key, partner or entry name.45in this module, the simple reconciliations works
4246on 2 lines (1 debit / 1 credit) and do not allow
43You may be interested to install also the account_advanced_reconciliation47partial reconcilation, they also match on 1 key,
44module available at: https://code.launchpad.net/c2c-financial-addons48partner or entry name.
45This latter add more complex reconciliations, allows multiple lines and partial.49
50You may be interested to install also the
51``account_advanced_reconciliation`` module.
52This latter add more complex reconciliations,
53allows multiple lines and partial.
4654
47""",55""",
48 "website" : "http://www.akretion.com/",56 "website" : "http://www.akretion.com/",
4957
=== modified file 'account_easy_reconcile/easy_reconcile.py'
--- account_easy_reconcile/easy_reconcile.py 2012-12-20 08:38:25 +0000
+++ account_easy_reconcile/easy_reconcile.py 2012-12-20 11:11:30 +0000
@@ -148,7 +148,6 @@
148 'name': fields.char('Name', size=64, required=True),148 'name': fields.char('Name', size=64, required=True),
149 'account': fields.many2one('account.account', 'Account', required=True),149 'account': fields.many2one('account.account', 'Account', required=True),
150 'reconcile_method': fields.one2many('account.easy.reconcile.method', 'task_id', 'Method'),150 'reconcile_method': fields.one2many('account.easy.reconcile.method', 'task_id', 'Method'),
151 'scheduler': fields.many2one('ir.cron', 'scheduler', readonly=True),
152 'unreconciled_count': fields.function(_get_total_unrec,151 'unreconciled_count': fields.function(_get_total_unrec,
153 type='integer', string='Unreconciled Entries'),152 type='integer', string='Unreconciled Entries'),
154 'reconciled_partial_count': fields.function(_get_partial_rec,153 'reconciled_partial_count': fields.function(_get_partial_rec,
@@ -166,13 +165,6 @@
166 readonly=True),165 readonly=True),
167 }166 }
168167
169 def copy_data(self, cr, uid, id, default=None, context=None):
170 if default is None:
171 default = {}
172 default = dict(default, scheduler=False)
173 return super(account_easy_reconcile, self).copy_data(
174 cr, uid, id, default=default, context=context)
175
176 def _prepare_run_transient(self, cr, uid, rec_method, context=None):168 def _prepare_run_transient(self, cr, uid, rec_method, context=None):
177 return {'account_id': rec_method.task_id.account.id,169 return {'account_id': rec_method.task_id.account.id,
178 'write_off': rec_method.write_off,170 'write_off': rec_method.write_off,
179171
=== modified file 'account_easy_reconcile/easy_reconcile.xml'
--- account_easy_reconcile/easy_reconcile.xml 2012-12-19 15:40:41 +0000
+++ account_easy_reconcile/easy_reconcile.xml 2012-12-20 11:11:30 +0000
@@ -15,7 +15,6 @@
15 <field name="account"/>15 <field name="account"/>
16 <field name="unreconciled_count"/>16 <field name="unreconciled_count"/>
17 <field name="reconciled_partial_count"/>17 <field name="reconciled_partial_count"/>
18 <field name="scheduler"/>
19 <separator colspan="4" string="Reconcile Method" />18 <separator colspan="4" string="Reconcile Method" />
20 <notebook colspan="4">19 <notebook colspan="4">
21 <page name="methods" string="Configuration">20 <page name="methods" string="Configuration">
@@ -67,7 +66,6 @@
67 <tree string="Automatic Easy Reconcile">66 <tree string="Automatic Easy Reconcile">
68 <field name="name"/>67 <field name="name"/>
69 <field name="account"/>68 <field name="account"/>
70 <field name="scheduler"/>
71 <field name="unreconciled_count"/>69 <field name="unreconciled_count"/>
72 <field name="reconciled_partial_count"/>70 <field name="reconciled_partial_count"/>
73 <button icon="gtk-ok" name="run_reconcile" colspan="4"71 <button icon="gtk-ok" name="run_reconcile" colspan="4"
@@ -87,7 +85,6 @@
87 <field name="res_model">account.easy.reconcile</field>85 <field name="res_model">account.easy.reconcile</field>
88 <field name="view_type">form</field>86 <field name="view_type">form</field>
89 <field name="view_mode">tree,form</field>87 <field name="view_mode">tree,form</field>
90 <field name="context">{'wizard_object' : 'account.easy.reconcile', 'function' : 'action_rec_auto', 'object_link' : 'account.easy.reconcile' }</field>
91 </record>88 </record>
9289
9390
@@ -135,16 +132,5 @@
135132
136 <menuitem action="action_account_easy_reconcile" id="menu_easy_reconcile" parent="account.periodical_processing_reconciliation"/>133 <menuitem action="action_account_easy_reconcile" id="menu_easy_reconcile" parent="account.periodical_processing_reconciliation"/>
137134
138
139<!-- button on the left -->
140
141 <record id="ir_action_create_scheduler_in_easy_reconcile" model="ir.values">
142 <field name="key2">client_action_multi</field>
143 <field name="model">account.easy.reconcile</field>
144 <field name="name">Create a Scheduler</field>
145 <field eval="'ir.actions.act_window,%d'%ref('base_scheduler_creator.action_scheduler_creator_wizard')" name="value"/>
146 <field eval="True" name="object"/>
147 </record>
148
149</data>135</data>
150</openerp>136</openerp>
151137
=== modified file 'account_easy_reconcile/i18n/fr.po'
--- account_easy_reconcile/i18n/fr.po 2012-12-20 09:04:42 +0000
+++ account_easy_reconcile/i18n/fr.po 2012-12-20 11:11:30 +0000
@@ -49,7 +49,7 @@
49#. module: account_easy_reconcile49#. module: account_easy_reconcile
50#: model:ir.model,name:account_easy_reconcile.model_easy_reconcile_options50#: model:ir.model,name:account_easy_reconcile.model_easy_reconcile_options
51msgid "easy.reconcile.options"51msgid "easy.reconcile.options"
52msgstr "lettrage automatisé.options"52msgstr "easy.reconcile.options"
5353
54#. module: account_easy_reconcile54#. module: account_easy_reconcile
55#: view:easy.reconcile.history:055#: view:easy.reconcile.history:0

Subscribers

People subscribed via source and target branches