Merge lp:~camptocamp/banking-addons/6.1-account_easy_reconcile-extract-dependency into lp:banking-addons/bank-statement-reconcile-61

Proposed by Guewen Baconnier @ Camptocamp
Status: Merged
Merge reported by: Joël Grand-Guillaume @ camptocamp
Merged at revision: not available
Proposed branch: lp:~camptocamp/banking-addons/6.1-account_easy_reconcile-extract-dependency
Merge into: lp:banking-addons/bank-statement-reconcile-61
Diff against target: 138 lines (+24/-38)
4 files modified
account_easy_reconcile/__openerp__.py (+23/-15)
account_easy_reconcile/easy_reconcile.py (+0/-8)
account_easy_reconcile/easy_reconcile.xml (+0/-14)
account_easy_reconcile/i18n/fr.po (+1/-1)
To merge this branch: bzr merge lp:~camptocamp/banking-addons/6.1-account_easy_reconcile-extract-dependency
Reviewer Review Type Date Requested Status
Joël Grand-Guillaume @ camptocamp Approve
Review via email: mp+140873@code.launchpad.net

This proposal supersedes a proposal from 2012-12-18.

Commit message

[FIX] remove the dependency on base_scheduler_creator and fix manifest's description

Description of the change

 * update the manifest description because account_advanced_reconcile is no longer in c2c-financial-addons

 * remove the dependency on base_scheduler_creator because it:
   - does not work on the web client
   - is not essential to use the addon (it would need to be put in a glue module, if it was working)
   - complicate the installation of the addon as it is not in the same branch

To post a comment you must log in.
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

LGTM

Thanks !

review: Approve
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote : Posted in a previous version of this proposal

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_easy_reconcile/__openerp__.py'
2--- account_easy_reconcile/__openerp__.py 2012-12-20 09:42:44 +0000
3+++ account_easy_reconcile/__openerp__.py 2012-12-20 11:11:30 +0000
4@@ -22,27 +22,35 @@
5 {
6 "name" : "Easy Reconcile",
7 "version" : "1.1",
8- "depends" : ["account", "base_scheduler_creator"
9+ "depends" : ["account",
10 ],
11 "author" : "Akretion,Camptocamp",
12 "description": """
13-This is a shared work between Akretion and Camptocamp in order to provide:
14+Easy Reconcile
15+==============
16+
17+This is a shared work between Akretion and Camptocamp
18+in order to provide:
19 - reconciliation facilities for big volume of transactions
20 - setup different profiles of reconciliation by account
21 - each profile can use many methods of reconciliation
22- - this module is also a base to create others reconciliation methods
23- which can plug in the profiles
24- - a profile a reconciliation can be run manually or by a cron
25- - monitoring of reconciliation runs with an history which keep track
26- of the reconciled entries
27-
28-2 simple reconciliation methods are integrated in this module, the simple
29-reconciliations works on 2 lines (1 debit / 1 credit) and do not allows
30-partial reconcilation, they also match on 1 key, partner or entry name.
31-
32-You may be interested to install also the account_advanced_reconciliation
33-module available at: https://code.launchpad.net/c2c-financial-addons
34-This latter add more complex reconciliations, allows multiple lines and partial.
35+ - this module is also a base to create others
36+ reconciliation methods which can plug in the profiles
37+ - a profile a reconciliation can be run manually
38+ or by a cron
39+ - monitoring of reconciliation runs with an history
40+ which keep track of the reconciled entries
41+
42+2 simple reconciliation methods are integrated
43+in this module, the simple reconciliations works
44+on 2 lines (1 debit / 1 credit) and do not allow
45+partial reconcilation, they also match on 1 key,
46+partner or entry name.
47+
48+You may be interested to install also the
49+``account_advanced_reconciliation`` module.
50+This latter add more complex reconciliations,
51+allows multiple lines and partial.
52
53 """,
54 "website" : "http://www.akretion.com/",
55
56=== modified file 'account_easy_reconcile/easy_reconcile.py'
57--- account_easy_reconcile/easy_reconcile.py 2012-12-20 08:38:25 +0000
58+++ account_easy_reconcile/easy_reconcile.py 2012-12-20 11:11:30 +0000
59@@ -148,7 +148,6 @@
60 'name': fields.char('Name', size=64, required=True),
61 'account': fields.many2one('account.account', 'Account', required=True),
62 'reconcile_method': fields.one2many('account.easy.reconcile.method', 'task_id', 'Method'),
63- 'scheduler': fields.many2one('ir.cron', 'scheduler', readonly=True),
64 'unreconciled_count': fields.function(_get_total_unrec,
65 type='integer', string='Unreconciled Entries'),
66 'reconciled_partial_count': fields.function(_get_partial_rec,
67@@ -166,13 +165,6 @@
68 readonly=True),
69 }
70
71- def copy_data(self, cr, uid, id, default=None, context=None):
72- if default is None:
73- default = {}
74- default = dict(default, scheduler=False)
75- return super(account_easy_reconcile, self).copy_data(
76- cr, uid, id, default=default, context=context)
77-
78 def _prepare_run_transient(self, cr, uid, rec_method, context=None):
79 return {'account_id': rec_method.task_id.account.id,
80 'write_off': rec_method.write_off,
81
82=== modified file 'account_easy_reconcile/easy_reconcile.xml'
83--- account_easy_reconcile/easy_reconcile.xml 2012-12-19 15:40:41 +0000
84+++ account_easy_reconcile/easy_reconcile.xml 2012-12-20 11:11:30 +0000
85@@ -15,7 +15,6 @@
86 <field name="account"/>
87 <field name="unreconciled_count"/>
88 <field name="reconciled_partial_count"/>
89- <field name="scheduler"/>
90 <separator colspan="4" string="Reconcile Method" />
91 <notebook colspan="4">
92 <page name="methods" string="Configuration">
93@@ -67,7 +66,6 @@
94 <tree string="Automatic Easy Reconcile">
95 <field name="name"/>
96 <field name="account"/>
97- <field name="scheduler"/>
98 <field name="unreconciled_count"/>
99 <field name="reconciled_partial_count"/>
100 <button icon="gtk-ok" name="run_reconcile" colspan="4"
101@@ -87,7 +85,6 @@
102 <field name="res_model">account.easy.reconcile</field>
103 <field name="view_type">form</field>
104 <field name="view_mode">tree,form</field>
105- <field name="context">{'wizard_object' : 'account.easy.reconcile', 'function' : 'action_rec_auto', 'object_link' : 'account.easy.reconcile' }</field>
106 </record>
107
108
109@@ -135,16 +132,5 @@
110
111 <menuitem action="action_account_easy_reconcile" id="menu_easy_reconcile" parent="account.periodical_processing_reconciliation"/>
112
113-
114-<!-- button on the left -->
115-
116- <record id="ir_action_create_scheduler_in_easy_reconcile" model="ir.values">
117- <field name="key2">client_action_multi</field>
118- <field name="model">account.easy.reconcile</field>
119- <field name="name">Create a Scheduler</field>
120- <field eval="'ir.actions.act_window,%d'%ref('base_scheduler_creator.action_scheduler_creator_wizard')" name="value"/>
121- <field eval="True" name="object"/>
122- </record>
123-
124 </data>
125 </openerp>
126
127=== modified file 'account_easy_reconcile/i18n/fr.po'
128--- account_easy_reconcile/i18n/fr.po 2012-12-20 09:04:42 +0000
129+++ account_easy_reconcile/i18n/fr.po 2012-12-20 11:11:30 +0000
130@@ -49,7 +49,7 @@
131 #. module: account_easy_reconcile
132 #: model:ir.model,name:account_easy_reconcile.model_easy_reconcile_options
133 msgid "easy.reconcile.options"
134-msgstr "lettrage automatisé.options"
135+msgstr "easy.reconcile.options"
136
137 #. module: account_easy_reconcile
138 #: view:easy.reconcile.history:0

Subscribers

People subscribed via source and target branches