Code review comment for lp:~camptocamp/anybox.recipe.openerp/20121204-add-daemon

Revision history for this message
Georges Racinet (gracinet) wrote :

Just did a really quick read. That looks overall good, but I (we) will need a bit more time to review/merge that one.

About the use-case itself, at Anybox, we use supervisor to handle daemonization, console logs and startup. That explains the lack of such in the recipe. We have self-contained instances, with a supervisor part with the dedicated recipe as well as mutualizing servers, where a distribution-installed supervisor takes care of several buildout-built instances.

In the future, we may switch to circus (looks promising). Some other people may use other supervision processes, so I think we should maybe introduce a class of options for that purpose, in order to avoid confusion with too many different configuration files/scripts being generated.

« Back to merge proposal