Code review comment for lp:~camptocamp/account-invoicing/7.0-add-swedish_rounding-yvr

Revision history for this message
Leonardo Pistone (lepistone) wrote :

Good!

One small remark: why is the function _all_invoice_tax_line_computed not in the invoice class?

To show that it does not use any class or instance data, we can make it a @staticmethod.

I do not consider this a significant problem though, so I approve in any case.

Thanks

review: Approve (code review)

« Back to merge proposal