Merge lp:~camptocamp/account-invoice-report/account-invoice-report-fix-supplier-view into lp:~account-core-editors/account-invoice-report/7.0

Proposed by Nicolas Bessi - Camptocamp
Status: Merged
Merge reported by: Joël Grand-Guillaume @ camptocamp
Merged at revision: not available
Proposed branch: lp:~camptocamp/account-invoice-report/account-invoice-report-fix-supplier-view
Merge into: lp:~account-core-editors/account-invoice-report/7.0
Diff against target: 68 lines (+43/-1)
3 files modified
invoice_webkit/__init__.py (+2/-1)
invoice_webkit/product.py (+30/-0)
invoice_webkit/view/invoice_view.xml (+11/-0)
To merge this branch: bzr merge lp:~camptocamp/account-invoice-report/account-invoice-report-fix-supplier-view
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp code review, no test Approve
Review via email: mp+145836@code.launchpad.net

Description of the change

Add form view in supplier invoice line

To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

There seem to be 2 changes in the patch : one adding the form and the other one adding the purchase_ok field (workaround for a bug). Is this intended?

review: Needs Information (code review, no test)
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Hello,

It is explicitly written in class doc string.

Regards

Nicolas

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) :
review: Approve (code review, no test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'invoice_webkit/__init__.py'
--- invoice_webkit/__init__.py 2013-01-24 15:28:47 +0000
+++ invoice_webkit/__init__.py 2013-01-31 13:12:32 +0000
@@ -19,4 +19,5 @@
19#19#
20##############################################################################20##############################################################################
21from . import invoice21from . import invoice
22from . import report
23\ No newline at end of file22\ No newline at end of file
23from . import report
24from . import product
2425
=== added file 'invoice_webkit/product.py'
--- invoice_webkit/product.py 1970-01-01 00:00:00 +0000
+++ invoice_webkit/product.py 2013-01-31 13:12:32 +0000
@@ -0,0 +1,30 @@
1# -*- coding: utf-8 -*-
2##############################################################################
3#
4# Copyright (c) 2011 Camptocamp SA (http://www.camptocamp.com)
5# @author Guewen Baconnier, Bessi Nicolas, Vincent Renaville
6#
7# This program is free software: you can redistribute it and/or modify
8# it under the terms of the GNU Affero General Public License as
9# published by the Free Software Foundation, either version 3 of the
10# License, or (at your option) any later version.
11#
12# This program is distributed in the hope that it will be useful,
13# but WITHOUT ANY WARRANTY; without even the implied warranty of
14# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15# GNU Affero General Public License for more details.
16#
17# You should have received a copy of the GNU Affero General Public License
18# along with this program. If not, see <http://www.gnu.org/licenses/>.
19#
20##############################################################################
21from openerp.osv import orm, fields
22
23
24class ProductTemplate(orm.Model):
25 """TMP fix of bug 1111430"""
26 _inherit = 'product.template'
27
28 _columns = {'purchase_ok': fields.boolean('Can be Purchased',
29 help=("Specify if the product can be selected"
30 " in a purchase order line."))}
031
=== modified file 'invoice_webkit/view/invoice_view.xml'
--- invoice_webkit/view/invoice_view.xml 2013-01-18 11:56:01 +0000
+++ invoice_webkit/view/invoice_view.xml 2013-01-31 13:12:32 +0000
@@ -75,6 +75,17 @@
75 </field>75 </field>
76 </record>76 </record>
7777
78 <record model="ir.ui.view" id="invoice_form_add_notes_in_invoice_line_1b">
79 <field name="name">account.invoice.form.add.supplier.notes</field>
80 <field name="model">account.invoice</field>
81 <field name="inherit_id" ref="account.invoice_supplier_form"/>
82 <field name="arch" type="xml">
83 <xpath expr="//field[@name='invoice_line']/tree" position="attributes" >
84 <attribute name="editable" eval="False"/>
85 </xpath>
86 </field>
87 </record>
88
78 <record model="ir.ui.view" id="invoice_form_add_notes_in_invoice_line_2">89 <record model="ir.ui.view" id="invoice_form_add_notes_in_invoice_line_2">
79 <field name="name">account.invoice.form.add.notes</field>90 <field name="name">account.invoice.form.add.notes</field>
80 <field name="model">account.invoice.line</field>91 <field name="model">account.invoice.line</field>

Subscribers

People subscribed via source and target branches