Code review comment for lp:~camptocamp/account-consolidation/fix-domain-nbi

Revision history for this message
Leonardo Pistone (lepistone) wrote :

On a low-level, I see that elements of curr_ids that are not in ids should not change the result. So I approve the fix.

On the other hand, I don't get what the method does. Could you take the occasion to add a docstring or comment, and maybe rename tid, ids, curr_ids ...

thanks!

review: Approve

« Back to merge proposal