Account - Consolidation

Code review comment for lp:~camptocamp/account-consolidation/7.0-account_consolidation-migr

  1. 7.0-account_consolidation-migr
  2. Merge into 7.0
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

992 + :param fyear_id: ID of the fiscal years to compare

-> if it is a single fiscal year, then s/years/year/. Otherwise, the arg should be renamed fyear_ids.

1758 + return account.user_type.consolidation_rate_type_id

-> I think you want to return account.user_type.consolidation_rate_type_id.id (according to the original code)

review: Needs Fixing (code review, no test)

« Back to merge proposal