Code review comment for lp:~camptocamp/account-budgeting/7.0-budget-add-allocation-resubmit-mdh
Revision history for this message
| Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote | # |
review:
Needs Fixing
(code review, no tests)
budget_line.py|21 col 1| F401 'datetime' imported but unused
budget_line.py|22 col 1| F401 'attrgetter' imported but unused
_sum_columns could get a better doc string to explain it updates the res dict parameter
l.146 extra space at "col 1" in comment it wouldn't work with split in the next list comprehension
BTW can't orderby accept string as "col1, col2 ASC, col3 DESC, col4" ?
l.150 ? :o)
Plus it will fail with an "out of range" exception with a groupby on which ASC or DESC is not defined
What about?
reverse = len(order[0]) == 2 and order[0][1] == 'DESC'
As if not specified means "ASC"