Merge ~callmepk/ubuntu-release-upgrader:ubuntu/focal into ubuntu-release-upgrader:ubuntu/focal

Proposed by Patrick Wu
Status: Needs review
Proposed branch: ~callmepk/ubuntu-release-upgrader:ubuntu/focal
Merge into: ubuntu-release-upgrader:ubuntu/focal
Diff against target: 23 lines (+13/-0)
1 file modified
DistUpgrade/DistUpgradeQuirks.py (+13/-0)
Reviewer Review Type Date Requested Status
Brian Murray Pending
Review via email: mp+401850@code.launchpad.net
To post a comment you must log in.

Unmerged commits

ec9aa7d... by Patrick Wu

Fix snap connectivity check failed silently when snapd service not
enabled (LP: #1926267)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/DistUpgrade/DistUpgradeQuirks.py b/DistUpgrade/DistUpgradeQuirks.py
2index 28122bb..acd217b 100644
3--- a/DistUpgrade/DistUpgradeQuirks.py
4+++ b/DistUpgrade/DistUpgradeQuirks.py
5@@ -548,6 +548,19 @@ class DistUpgradeQuirks(object):
6 elif 'error: access denied' in connected[1]:
7 res = False
8 logging.error("Not running as root!")
9+ elif '/run/snapd.socket: connect: no such file or directory' in connected[1]:
10+ summary = _("Connection to the snapd service failed")
11+ msg = _("Connection to the snapd service failed. "
12+ "Please make sure snapd service is enabled "
13+ "in the systemd before release upgrade.\n"
14+ "For WSL users, due to lack of support for "
15+ "systemd, snap will not able to "
16+ "work properly. Please remove snapd package "
17+ "before the distribution update."
18+ )
19+ self._view.error(summary, msg)
20+ self.controller.abort()
21+ )
22 if not res:
23 self.controller.abort()
24

Subscribers

People subscribed via source and target branches