Merge ~caleb-ellis/maas:1811669-edit-mount-points into maas:master

[Caleb Ellis]

LP: #1811669 - hide storage actions that auth user cannot perform

## Done
- Hide storage layout options that the current logged in user cannot perform.
- Added a guard to $scope.canPerformActionOnDatastoreSet if no $scope.storageLayout

## QA
- Go to the storage tab of a machine that you have permission to edit (i.e. user/admin) and check that you can still perform all actions as normal (e.g change storage layout, mount/unmount filesystems, edit partitions etc)
- Go to the storage tab of a machine that you can view but cannot edit (i.e. auditor) and check that you can see all the storage information, but cannot edit any of it.

## Screenshots
### Machine that you are a user/admin of
https://user-images.githubusercontent.com/25733845/58331767-c380b480-7e31-11e9-96eb-927f1230db2c.png

### Machine that you are an auditor of
https://user-images.githubusercontent.com/25733845/58331778-c7acd200-7e31-11e9-9a48-14ca39e065b8.png

[Steve Rydz (steverydz)]

LGTM +1

review: Approve

[Alberto Donato (ack)]

lgtm

review: Approve

diff --git a/src/maasserver/static/js/angular/controllers/node_details_storage.js b/src/maasserver/static/js/angular/controllers/node_details_storage.js
index 749abca..f0cb5c5 100644
--- a/src/maasserver/static/js/angular/controllers/node_details_storage.js
+++ b/src/maasserver/static/js/angular/controllers/node_details_storage.js
@@ -283,7 +283,7 @@ export function NodeStorageController(
   $scope.canPerformActionOnDatastoreSet = function() {
     var editing = $scope.addToExistingDatastore || $scope.createNewDatastore;
     var selected = $scope.selectedAvailableDatastores.length > 0;
-    var vmfs6 = $scope.storageLayout.id === "vmfs6";
+    var vmfs6 = $scope.storageLayout && $scope.storageLayout.id === "vmfs6";
     return !editing && selected && vmfs6;
   };
 
diff --git a/src/maasserver/static/partials/node-details.html b/src/maasserver/static/partials/node-details.html
index 7d4e436..864da70 100755
--- a/src/maasserver/static/partials/node-details.html
+++ b/src/maasserver/static/partials/node-details.html
@@ -2932,7 +2932,7 @@
 
     <section class="p-strip u-no-padding--bottom" data-ng-if="section.area === 'storage'" data-ng-controller="NodeStorageController">
         <form>
-            <div data-ng-if="node.status_code === 4 || node.status_code === 10">
+            <div data-ng-if="canEdit() && (node.status_code === 4 || node.status_code === 10)">
                 <div class="row" data-ng-if="!confirmStorageLayout">
                     <div class="col-12 prefix-9 u-sv3">
                         <div class="p-form__group u-align--right">
@@ -3021,7 +3021,7 @@
 
                 <div class="row">
                     <div data-ng-controller="NodeFilesystemsController" data-ng-if="storageLayout.id !== 'vmfs6'">
-                        <storage-filesystems></storage-filesystems>
+                        <storage-filesystems canEdit="canEdit()"></storage-filesystems>
                     </div>
                     <div data-ng-show="cachesets.length">
                         <div class="row">
diff --git a/src/maasserver/static/partials/nodedetails/storage/disks-partitions.html b/src/maasserver/static/partials/nodedetails/storage/disks-partitions.html
index 4661058..c5b6067 100644
--- a/src/maasserver/static/partials/nodedetails/storage/disks-partitions.html
+++ b/src/maasserver/static/partials/nodedetails/storage/disks-partitions.html
@@ -5,7 +5,7 @@
             <thead>
                 <tr class="p-table__row">
                     <th class="p-double-row p-table__cell">
-                        <div class="p-double-row__checkbox">&nbsp;</div>
+                        <div data-ng-if="canEdit()" class="p-double-row__checkbox">&nbsp;</div>
                         <div class="p-double-row__rows-container--checkbox">
                             <div>Name</div>
                             <div>Serial</div>
@@ -22,7 +22,7 @@
                         <div>Tags</div>
                     </th>
                     <th class="p-table__cell">Health</th>
-                    <th class="p-table__cell"><div class="u-align--right">Actions</div></th>
+                    <th data-ng-if="canEdit()" class="p-table__cell"><div class="u-align--right">Actions</div></th>
                 </tr>
             </thead>
             <tbody>
@@ -35,11 +35,11 @@
                     data-ng-class="{ 'is-active': item.$selected }" data-ng-if="item.parent_type !== 'vmfs6'">
                     <td class="p-form-validation p-double-row p-table__cell" aria-label="Name"
                         data-ng-class="{ 'is-error': isNameInvalid(item) }">
-                        <div class="p-double-row__checkbox">
+                        <div data-ng-if="canEdit()" class="p-double-row__checkbox">
                             <input type="checkbox" class="checkbox u-float--left" id="{$ item.name $}" data-ng-hide="isAvailableDisabled()" data-ng-checked="item.$selected" data-ng-click="toggleAvailableSelect(item)" data-ng-disabled="isAvailableDisabled()" />
                             <label for="{$ item.name $}"></label>
                         </div>
-                        <div class="p-double-row__rows-container--checkbox">
+                        <div data-ng-class="{'p-double-row__rows-container--checkbox': canEdit(), 'p-double-row__rows-container': !canEdit()}">
                             <div class="p-double-row__main-row">
                                 {$ item.name $}
                             </div>
@@ -93,7 +93,7 @@
                         <span data-ng-if="item.test_status === 6" title="Degraded">Degraded</span>
                         <span data-ng-if="item.test_status === -1" title="Unknown">Unknown</span>
                     </td>
-                    <td class="p-table--action-cell p-table__cell">
+                    <td data-ng-if="canEdit()" class="p-table--action-cell p-table__cell">
                         <div class="u-align--right">
                             <div class="p-contextual-menu" toggle-ctrl
                                 data-ng-if="canAddLogicalVolume(item) || canAddPartition(item) || canEdit(item) || canDelete(item)">
diff --git a/src/maasserver/static/partials/nodedetails/storage/filesystems.html b/src/maasserver/static/partials/nodedetails/storage/filesystems.html
index 908e7aa..74595f4 100644
--- a/src/maasserver/static/partials/nodedetails/storage/filesystems.html
+++ b/src/maasserver/static/partials/nodedetails/storage/filesystems.html
@@ -9,7 +9,7 @@
                 <th scope="col" aria-sort="none" class="col-2">Filesystem</th>
                 <th scope="col" aria-sort="none" class="col-2">Mount point</th>
                 <th scope="col" aria-sort="none" class="col-3">Mount options</th>
-                <th scope="col" aria-sort="none" class="col-1 u-align--right">Actions</th>
+                <th data-ng-if="canEdit()" scope="col" aria-sort="none" class="col-1 u-align--right">Actions</th>
                 <th class="u-hide"><!-- empty cell for validation --></th>
             </tr>
         </thead>
@@ -29,7 +29,7 @@
                     filesystem.mount_point $}</td>
                 <td role="gridcell" class="col-3" aria-label="Mount options" title="{$ filesystem.mount_options $}">{$
                     filesystem.mount_options $}</td>
-                <td role="gridcell" class="col-1 p-table--action-cell u-align--right">
+                <td data-ng-if="canEdit()" role="gridcell" class="col-1 p-table--action-cell u-align--right">
                     <div class="p-contextual-menu" toggle-ctrl data-ng-if="!isAllStorageDisabled()">
                         <button class="p-button--base p-contextual-menu__toggle" aria-controls="#{$ item.name $}-menu"
                             data-ng-click="toggleMenu()" aria-haspopup="true">
@@ -111,7 +111,7 @@
         </tbody>
     </table>
     <button class="p-button--neutral p-tooltip--top-left" data-ng-disabled="dropdown !== null" data-ng-class="{ 'p-tooltip': dropdown === null}"
-        data-ng-if="!isAllStorageDisabled()" data-ng-click="addSpecialFilesystem()">
+        data-ng-if="canEdit()" data-ng-click="addSpecialFilesystem()">
         Add special filesystem
         <span class="p-tooltip__message" role="tooltip">Create a tmpfs or ramfs filesystem</span>
     </button>