Merge ~caleb-ellis/maas:filter-count into maas:master

[Caleb Ellis]

LP: #1829225 - Fix incorrect filter counts in machine list

## Done
- Fixed incorrect filter counts in machine list. This was occurring due to not properly clearing the metadata when loading the machine list, so the counts were getting added to every time you navigated to the machine list. This fix introduces two-way binding for the machine metadata, which is not ideal but ensures that the metadata is always correct.

## QA
- Go to machine list
- Check that the filter dropdown counts are correct
- Navigate to a different page then navigate back to the machine list
- Check that the machines still load in batches
- Check that the filter dropdowns are still correct

[Anthony Dillon (ya-bo-ng)]

LGTM +1

review: Approve

diff --git a/src/maasserver/static/js/angular/directives/machines_table.js b/src/maasserver/static/js/angular/directives/machines_table.js
index 7ccfe0c..295272b 100644
--- a/src/maasserver/static/js/angular/directives/machines_table.js
+++ b/src/maasserver/static/js/angular/directives/machines_table.js
@@ -33,7 +33,8 @@ function maasMachinesTable(
       onCheckAll: "&",
       onCheck: "=",
       pools: "=",
-      zones: "="
+      zones: "=",
+      metadata: "="
     },
     templateUrl:
       "static/partials/machines-table.html?v=" +
@@ -78,7 +79,8 @@ function maasMachinesTable(
     // ng-repeats the initial digest cycle is slow and the UI is
     // blocked on first navigation.
     if (angular.isDefined($scope.loading)) {
-      MachinesManager.clearItems();
+      MachinesManager.clear();
+      $scope.metadata = MachinesManager.getMetadata();
     }
     const machines = MachinesManager.getItems();
 
diff --git a/src/maasserver/static/partials/nodes-list.html b/src/maasserver/static/partials/nodes-list.html
index f4898b9..8e7fe41 100644
--- a/src/maasserver/static/partials/nodes-list.html
+++ b/src/maasserver/static/partials/nodes-list.html
@@ -992,7 +992,8 @@ sudo maas-rack register --url {$ tabs.controllers.registerUrl $} --secret {$ tab
                         on-check-all="toggleCheckAll('machines')"
                         on-check="toggleChecked($machine, 'machines')"
                         pools="pools"
-                        zones="zones">
+                        zones="zones"
+                        metadata=tabs.machines.metadata>
                     </maas-machines-table>
                 </div>
             </form>