Merge ~caleb-ellis/maas:no-commission-test-suppress into maas:master

[Caleb Ellis]

LP: #1828492 - Remove ability to suppress failed commissioning scripts via UI

## Done
- Hide suppress column and checkboxes in commissioning tab in node details
- Remove suppress option from action menu

## QA
- Check that you can't suppress commissioning scripts via the UI
- Check that you can still suppress individual tests in the hardware tests tab

## Screenshot
https://user-images.githubusercontent.com/25733845/57514184-c2b33300-7307-11e9-81a5-9cac1c8469a1.png

[Steve Rydz (steverydz)]

LGTM +1

review: Approve

diff --git a/src/maasserver/static/partials/script-results-list.html b/src/maasserver/static/partials/script-results-list.html
index e68534f..56fd2be 100644
--- a/src/maasserver/static/partials/script-results-list.html
+++ b/src/maasserver/static/partials/script-results-list.html
@@ -23,7 +23,7 @@
                     <table class="p-table-expanding p-table--controllers-commissioning">
                         <thead>
                             <tr>
-                                <th style="width: 80px">Suppress</th>
+                                <th data-ng-if="nodeResultsManager._area === 'testing'" style="width: 80px">Suppress</th>
                                 <th class="col-3">Name</th>
                                 <th class="col-2">Tags</th>
                                 <th class="col-1">Runtime</th>
@@ -40,7 +40,11 @@
                                     'is-suppressed': result.suppressed
                                 }"
                             >
-                                <td style="width: 80px; overflow: visible" aria-label="Suppress"">
+                                <td
+                                    data-ng-if="nodeResultsManager._area === 'testing'"
+                                    style="width: 80px; overflow: visible"
+                                    aria-label="Suppress"
+                                >
                                     <div class="p-tooltip">
                                         <input
                                             id="{$ result.id $}"
@@ -81,7 +85,7 @@
                                                 <button class="p-contextual-menu__link" aria-label="Hide metrics" data-ng-if="result.showing_results" data-ng-click="toggleMenu(); result.showing_history = false; result.showing_results = false">Hide metrics</button>
                                                 <button class="p-contextual-menu__link" aria-label="View previous {$ result.result_section $}" data-ng-if="!result.showing_history" data-ng-click="toggleMenu(); loadHistory(result)">View previous {$ result.result_section $}</button>
                                                 <button class="p-contextual-menu__link" aria-label="Hide previous {$ result.result_section $}" data-ng-if="result.showing_history" data-ng-click="toggleMenu(); result.showing_results = false; result.showing_history = false">Hide previous {$ result.result_section $}</button>
-                                                <button class="p-contextual-menu__link" aria-label="Toggle this test in machine list" data-ng-if="isSuperUser() && isSuppressible(result)" data-ng-click="toggleSuppressed(result)">{$ result.suppressed ? "Show" : "Suppress" $} test in machine list</button>
+                                                <button class="p-contextual-menu__link" aria-label="Toggle this test in machine list" data-ng-if="isSuperUser() && isSuppressible(result) && nodeResultsManager._area === 'testing'" data-ng-click="toggleSuppressed(result)">{$ result.suppressed ? "Show" : "Suppress" $} test in machine list</button>
                                             </div>
                                         </div>
                                     </div>