Code review comment for ~caleb-ellis/maas:suppress-single-test

Revision history for this message
Lee Trager (ltrager) wrote :

I just tested this branch and if I click hide nothing happens, same if I try the option in the menu list. I also noticed that the 'hide' check box is shown for aborted and pending, installing, and running statuses. It should only be shown if the test has failed, failed installing, or timed out.

I still think we need to be consistent between in naming between the API and UI. Users often do something in the UI and then try to automate that process. The API currently calls this suppress and does not mention 'hiding' at all. This will leave users confused as to how to 'hide' a ScriptResult with the API. I'd be open to changing the API to 'hide' if we agree that is a better name however we have already released a few beta's with this being called suppress so changing at this point would cause API breakage.

review: Needs Fixing

« Back to merge proposal