Code review comment for ~caleb-ellis/maas:suppress-single-test

Revision history for this message
Caleb Ellis (caleb-ellis) wrote :

> I agree with Blake that the column should be called Suppressed like it is on
> the API.
>
> In master we have set_script_result_suppressed which is the inverse of
> set_script_result_unsuppressed that Cabel implemented. I think we should fix
> both in a separate bug. However the UI should be updated to also send the
> system_id.

Alright I've updated so the UI sends through the node system_id, and I'm okay to leave the permissions issue with you?

« Back to merge proposal