Code review comment for ~caleb-ellis/maas:suppress-single-test

I aggree for historical features that have established use in CLI and code,
that the GUI should reflect the API, so users who already know one can
recognise the feature as the same.

In this case, it's a new feature, and we can call it what we want, to
reflect the functionality.

--
Separate question. Is "supress" a good name? I can live with it, but I've
never liked it. It sounds more technical than it really is.

"Hide" is simpler, more honest language that's immediately understandable,
unambiguous.

Some of our language, eg. "commission" and "deploy" follow industry
practice, so they're the right word, even though they're slightly
ridiculous. You commission officers and deploy troops. I wonder why all
this language is so military?

So perhaps that's why "Suppress" - it's what the First Order does to The
Resistance?

But please, what we really mean here is "Hide".

On Fri, Apr 26, 2019 at 7:42 AM Lee Trager <email address hidden> wrote:

> Review: Needs Fixing
>
> I agree with Blake that the column should be called Suppressed like it is
> on the API.
>
> In master we have set_script_result_suppressed which is the inverse of
> set_script_result_unsuppressed that Cabel implemented. I think we should
> fix both in a separate bug. However the UI should be updated to also send
> the system_id.
> --
> https://code.launchpad.net/~caleb-ellis/maas/+git/maas/+merge/366513
> Your team MAAS UI team is requested to review the proposed merge of
> ~caleb-ellis/maas:suppress-single-test into maas:master.
>