Merge ~caleb-ellis/maas:action-notification-deploy into maas:master

[Caleb Ellis]

LP: #1797896 - Hide action notification warning if actions are in progress

## Done

- Hide actionError warning if actions are currently in progress (e.g. deploying/commissioning etc.)

## QA

- Deploy/commission a few machines
- Check that the warning does not appear

## Screenshots
https://user-images.githubusercontent.com/25733845/48562424-11988680-e8ea-11e8-90a1-b8ebf063bcf3.png

[MAAS Lander (maas-lander)]

UNIT TESTS
-b action-notification-deploy lp:~caleb-ellis/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 8fa7c34e2cb1e45b1fe35aa6803e13b5ed4ee95e

review: Approve

[Lilyana Videnova (lilyanavidenova)]

review: Approve

[Martin Storey (cassiocassio)]

How about:

```
16 nodes could not be deployed, and 4 nodes are already being deployed.<br>
To proceed, <a>refine your selection</a> to the 7 deployable nodes.
```

tricky plurals:

```
16 nodes could not be deployed, and 4 nodes are already being deployed.<br>
To proceed, <a>refine your selection</a> to the deployable node.
```

```
1 node could not be deployed, and 1 node is already being deployed.<br>
To proceed, <a>refine your selection</a> to the 7 deployable nodes.
```

review: Needs Fixing

[Andres Rodriguez (andreserl)]

Please, read my last comment in https://bugs.launchpad.net/maas/+bug/1797896/comments/4

That said, I think we are over complicating the message. In my opinion, it is better to keep the message more high level. E.g. machines can be in New, Commissioning, Testing, Broken, Ready and the user can select and try to deploy them. Representing messages for each of these things is difficult and doesn't really provide any real benefit.

I think we should re-think this in the future and address the more immediate issue first, having a high level meessage.

[Andres Rodriguez (andreserl)]

review: Needs Information

9d8ced6... by Caleb Ellis on 2018-11-15

LP: #1797896 - Hide action notification warning if actions are in progress

[MAAS Lander (maas-lander)]

UNIT TESTS
-b action-notification-deploy lp:~caleb-ellis/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 9d8ced67eb5dd5ca019f37e1e2c4736126f1f98e

review: Approve

[Caleb Ellis (caleb-ellis)]

MP updated to simply hide warning notification if actions are currently in progress

[Andres Rodriguez (andreserl)]

lgtm!

review: Approve

diff --git a/src/maasserver/static/partials/nodes-list.html b/src/maasserver/static/partials/nodes-list.html
index d24c208..3fdfe9b 100644
--- a/src/maasserver/static/partials/nodes-list.html
+++ b/src/maasserver/static/partials/nodes-list.html
@@ -349,14 +349,14 @@
             </section>
 
             <!-- XXX ricgard 2016-06-16 - Need to add e2e test. -->
-            <section class="page-header__section row u-no-margin--top ng-hide" data-ng-show="isActionError(tab)">
+            <section class="page-header__section row u-no-margin--top" data-ng-hide="!isActionError(tab) || hasActionsInProgress(tab)">
                 <div class="col-12">
                     <div class="row">
                         <p data-ng-hide="isDeployError(tab) || isSSHKeyError(tab)"
                             class="page-header__message page-header__message--error ng-hide">
                             <i class="p-icon--warning">Warning</i>
                             {$ tabs[tab].actionErrorCount $}
-                            <span data-ng-pluralize count="tabs[tab].selectedItems.length" when="{'one': 'node', 'other': 'nodes'}"></span>
+                            <span data-ng-pluralize count="tabs[tab].actionErrorCount" when="{'1': 'node', 'other': 'nodes'}"></span>
                             cannot be {$ tabs[tab].actionOption.sentence $}. To proceed, <a data-ng-click="unselectImpossibleNodes(tab)">update your selection</a>.
                         </p>
                         <p class="page-header__message page-header__message--error ng-hide" data-ng-show="isDeployError(tab)">