Merge lp:~caelj/spenglr-core/theme-first-pass-reconciled into lp:spenglr-core/theme-trunk
Proposed by
Cael Kay-Jackson
| Status: | Merged |
|---|---|
| Approved by: | Martin Fitzpatrick |
| Approved revision: | 16 |
| Merged at revision: | not available |
| Proposed branch: | lp:~caelj/spenglr-core/theme-first-pass-reconciled |
| Merge into: | lp:spenglr-core/theme-trunk |
| To merge this branch: | bzr merge lp:~caelj/spenglr-core/theme-first-pass-reconciled |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Fitzpatrick (community) | Approve | ||
| Cael Kay-Jackson (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Cael Kay-Jackson (caelj) wrote | # |
This is now in a usable state and can be merged into the core theme trunk (along with the corresponding merges for .com and .org).
A few things remain to be tackled however, such as the rtl stylesheet and output of elements that aren't currently supported (primary links, secondary links, site name, site slogan, etc.), along with tidying up some of the files that haven't received any love (ie fix stylesheets for example still contain quite a bit of unused css).
This being said, these branches are a first pass and my work here is pretty much done. The basics are in place, providing a simple theme (the plan was to specifically not over-complicate the design) which can be modified by proper theme devs as and when they feel the urge.
The themes as currently setup are colored red for .com and blue for .org. These colors aren't deemed final and can be easily changed by virtue of the design purposely not using many graphics. In fact, for the core design only one graphic is used - that for the top logo - and the others are of 'generic' colors that are equally applicable to both themes. All other color stylings are done in css.
Regarding the generic coloring of the other files (for example fieldset gradients are light gray, not colored for the theme): This doesn't have to remain the case and we welcome anyone who wants to make updates in this respect to do so. For now it merely allows most files to be inherited by .com and .org subthemes from the parent .core theme.
The themes don't work with color.module, so all support for that has currently been removed. This also affected the com_user.module which made a call to a color.module function, which is a problem that may need to be revisited. Support for the color module may well be beneficial for changing color schemes without having to edit files or css directly.
Note that .core is themed in red and as such .com essentially inherits just about everything from it as is. .org makes only a few other alterations on top of this such as applying different colors in some css rules and providing a different logo image.