Code review comment for lp:~c10ud/indicator-application/runtime-themepath-change

Revision history for this message
Ted Gould (ted) wrote :

What do you guys think about changing the signal to include the path in it, that's save a DBus call. From:

+ <signal name="NewIconThemePath">
+ </signal>

To:

<signal name="NewIconThemePath">
<arg type="s" name="icon_theme_path" direction="out" />
</signal>

The others don't have properties becasue they could represent a few values changing, but this signal seems to be 1:1 with the theme path, so I'm thinking just send it.

Thoughts?

« Back to merge proposal