Code review comment for lp:~c-lobrano/snappy/hw-assign-fix-overwrite-udev-rule

Revision history for this message
John Lenton (chipaca) wrote :

Better!

Still two problems in the code. One in a comment below. The other is from golint:

snappy/hwaccess.go:119:35: don't use underscores in Go names; func parameter new_rule should be newRule
snappy/hwaccess.go:135:2: don't use underscores in Go names; var updated_rules should be updatedRules
snappy/hwaccess.go:238:3: don't use underscores in Go names; var device_pattern should be devicePattern

look at .precommit in the project root for help in having golint run automatically for you.

« Back to merge proposal