Merge lp:~c-e-pidcott/maus/1389a into lp:maus/merge

Proposed by Celeste Pidcott
Status: Merged
Merged at revision: 1075
Proposed branch: lp:~c-e-pidcott/maus/1389a
Merge into: lp:maus/merge
Diff against target: 25 lines (+2/-2)
2 files modified
bin/Global/pid_pdf_generator.py (+1/-1)
src/map/MapCppGlobalPID/MapCppGlobalPID.cc (+1/-1)
To merge this branch: bzr merge lp:~c-e-pidcott/maus/1389a
Reviewer Review Type Date Requested Status
Adam Dobbs Pending
Review via email: mp+292124@code.launchpad.net

Description of the change

Fixed a typo and made PDF generator use InputCppRootData

To post a comment you must log in.
Revision history for this message
Adam Dobbs (ajdobbs) wrote :

Thanks Celeste. Is InputCppRootData working? Last I looked it would fall over quite quickly with some sort of buffer overrun...

Revision history for this message
Celeste Pidcott (c-e-pidcott) wrote :

Um, it's never given me any problems and I've run it over hundreds of thousands of events...

On 18 Apr 2016 14:25, Adam Dobbs <email address hidden> wrote:
Thanks Celeste. Is InputCppRootData working? Last I looked it would fall over quite quickly with some sort of buffer overrun...
--
https://code.launchpad.net/~c-e-pidcott/maus/1389a/+merge/292124
You are the owner of lp:~c-e-pidcott/maus/1389a.

Revision history for this message
chrisrogers1234 (chris-rogers) wrote :

I've also used it quite a bit without a problem, but happy to receive a
bug report if there is something fishy.

Chris

On 18/04/16 14:54, Celeste Pidcott wrote:
> Um, it's never given me any problems and I've run it over hundreds of thousands of events...
>
> On 18 Apr 2016 14:25, Adam Dobbs <email address hidden> wrote:
> Thanks Celeste. Is InputCppRootData working? Last I looked it would fall over quite quickly with some sort of buffer overrun...
> --
> https://code.launchpad.net/~c-e-pidcott/maus/1389a/+merge/292124
> You are the owner of lp:~c-e-pidcott/maus/1389a.
>

--
ASTeC Intense Beams Group

tel: +44 (0)1235 44 6983

Building R2,
Rutherford Appleton Laboratory,
Harwell Science and Innovation Campus,
Didcot.
OX11 0QX

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/Global/pid_pdf_generator.py'
--- bin/Global/pid_pdf_generator.py 2016-02-17 01:31:25 +0000
+++ bin/Global/pid_pdf_generator.py 2016-04-18 09:44:09 +0000
@@ -16,7 +16,7 @@
16 """16 """
1717
18 # Take as input a maus root file.18 # Take as input a maus root file.
19 my_input = MAUS.InputCppRoot()19 my_input = MAUS.InputCppRootData()
2020
21 my_output = MAUS.OutputPyDoNothing()21 my_output = MAUS.OutputPyDoNothing()
2222
2323
=== modified file 'src/map/MapCppGlobalPID/MapCppGlobalPID.cc'
--- src/map/MapCppGlobalPID/MapCppGlobalPID.cc 2016-02-16 23:41:03 +0000
+++ src/map/MapCppGlobalPID/MapCppGlobalPID.cc 2016-04-18 09:44:09 +0000
@@ -560,7 +560,7 @@
560 const_cast<MAUS::DataStructure::Global::Track*>560 const_cast<MAUS::DataStructure::Global::Track*>
561 (const_tracks.at(track_j));561 (const_tracks.at(track_j));
562 perform_pid("MapCppGlobalPID-Final_Through_US",562 perform_pid("MapCppGlobalPID-Final_Through_US",
563 "Through_DS_PID", US_track, _pid_vars,563 "Through_US_PID", US_track, _pid_vars,
564 _pid_beamline_polarity,564 _pid_beamline_polarity,
565 _pid_beam_setting, global_event);565 _pid_beam_setting, global_event);
566 }566 }

Subscribers

People subscribed via source and target branches