Merge lp:~bzr/bzr/475585-lp-proxy-py24-compat into lp:bzr

Proposed by John A Meinel
Status: Merged
Merged at revision: not available
Proposed branch: lp:~bzr/bzr/475585-lp-proxy-py24-compat
Merge into: lp:bzr
Diff against target: 43 lines (+13/-2)
2 files modified
NEWS (+7/-0)
bzrlib/plugins/launchpad/lp_registration.py (+6/-2)
To merge this branch: bzr merge lp:~bzr/bzr/475585-lp-proxy-py24-compat
Reviewer Review Type Date Requested Status
bzr-core Pending
Review via email: mp+14492@code.launchpad.net
To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

This is Vincent's fix for XMLTransport not being compatible with python2.4 with a couple of small updates. The main one is to just move the NEWS entry to the right location.

I still don't have a good answer for Daggy Fixes + NEWS entries. Because you really need NEWS to be part of the statement where the patch *lands* and not where it was *based* on...

Anyway, since Vincent was happy with that fix, and *I'm* happy with the small comment tweaks here, I'm going to land this.

Now we just need to figure out what to do about 2.1.0b3. I *definitely* want to release it ahead of schedule, since this is a serious regression.

But do we just release it straight from an updated bzr.dev, or do we just apply this patch onto 2.1.0b2 and release that immediately.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NEWS'
--- NEWS 2009-11-04 22:29:40 +0000
+++ NEWS 2009-11-05 20:15:23 +0000
@@ -29,6 +29,7 @@
29 allow those because XML store silently translate it anyway. (The parser29 allow those because XML store silently translate it anyway. (The parser
30 auto-translates \r\n => \n in ways that are hard for us to catch.)30 auto-translates \r\n => \n in ways that are hard for us to catch.)
3131
32<<<<<<< TREE
32* On Windows, do glob expansion at the command-line level (as is usually33* On Windows, do glob expansion at the command-line level (as is usually
33 done in bash, etc.) This means that *all* commands get glob expansion34 done in bash, etc.) This means that *all* commands get glob expansion
34 (bzr status, bzr add, bzr mv, etc). It uses a custom command line35 (bzr status, bzr add, bzr mv, etc). It uses a custom command line
@@ -38,6 +39,12 @@
38 (John Arbash Meinel, #425510, #426410, #194450)39 (John Arbash Meinel, #425510, #426410, #194450)
3940
4041
42=======
43* The fix for bug #186920 accidentally broke compatibility with python
44 2.4. (Vincent Ladeuil, #475585)
45
46
47>>>>>>> MERGE-SOURCE
41Improvements48Improvements
42************49************
4350
4451
=== modified file 'bzrlib/plugins/launchpad/lp_registration.py'
--- bzrlib/plugins/launchpad/lp_registration.py 2009-10-30 21:02:37 +0000
+++ bzrlib/plugins/launchpad/lp_registration.py 2009-11-05 20:15:23 +0000
@@ -56,8 +56,12 @@
5656
57class XMLRPCTransport(xmlrpclib.Transport):57class XMLRPCTransport(xmlrpclib.Transport):
5858
59 def __init__(self, scheme, use_datetime=0):59 def __init__(self, scheme):
60 xmlrpclib.Transport.__init__(self, use_datetime=use_datetime)60 # In python2.4 xmlrpclib.Transport is a old-style class, and does not
61 # define __init__, so we check first
62 init = getattr(xmlrpclib.Transport, '__init__', None)
63 if init is not None:
64 init(self)
61 self._scheme = scheme65 self._scheme = scheme
62 self._opener = _urllib2_wrappers.Opener()66 self._opener = _urllib2_wrappers.Opener()
63 self.verbose = 067 self.verbose = 0