Code review comment for lp:~bzr/bzr/412930-plugin-path

>>>>> "jam" == John A Meinel <email address hidden> writes:

    jam> Alexander Belchenko wrote:
    >> 30 +* the size specific plugin directory if applicable (containing
    >> 31 + the site plugins).
    >>
    >> the size specific plugin directory? What is it?

    jam> site-specific.

Right. The intent is to give access to plugins installed by
whoever administer the site, this directory contains plugins that
can be used by all users.

    jam> It only really exists on Linux

Wrong.

The get_python_lib() doc string in distutils says:

    """Return the directory containing the Python library (standard or
    site additions).

    If 'plat_specific' is true, return the directory containing
    platform-specific modules, i.e. any module from a non-pure-Python
    module distribution; otherwise, return the platform-shared library
    directory. If 'standard_lib' is true, return the directory
    containing standard Python library modules; otherwise, return the
    directory for site-specific modules.

    If 'prefix' is supplied, use it instead of sys.prefix or
    sys.exec_prefix -- i.e., ignore 'plat_specific'.
    """

On linux it can be 'dist-packages' or 'site-packages' in the
python hierarchy.

On mac it's 'Lib/site-packages' but again the installers may be
wrong here (I don't know them enough to be sure, they may well be
right).

On os.name == "nt" (windows right ?) it seems to be
'Lib/site-packages'.

So, as I understand it, it makes no sense for bzr.exe (but we may
want to say it's 'All Users/Application Data/Bazaar/Plugins') and
when running from sources (or from easy_install when it will
work), we may want to activate it (in addition to 'All Users/...')

In the mean time, I kept the compatibility with previous versions
and add the win32 check that I accidentally removed in my patch.

Feedback welcome even if I think that should be the subject of
another submission are there are certainly tweaks to be done in
the windows installers.