Code review comment for ~bryce/ubuntu/+source/ssl-cert:ssl-cert-sru-lp1853021-hirsute

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Some more inline comments added

Also this has whitespace damage in line 40 (the original has that, but you could fix it in your proposal)

   39 done
   40 ····
   41 db_get make-ssl-cert/hostname

There are more - worth to clean up and unify when proposing to Debian IMHO.

In general some shellcheck treatment could raise the quality while we are at it.

« Back to merge proposal