Code review comment for ~bryce/ubuntu/+source/python-seamicroclient:python-seamicroclient-merge-v0.4.0-3-eoan

Oh, you must have meant add-pkg-info.patch

    - add-pkg-info.patch: Add PKG-INFO in top level dir so it doesn't FTBFS.

Yes, in the 0.4.0 package in eoan with quilt pop -a, I reproduce a build error running

    python setup.py build

    (...)
    File "/usr/lib/python2.7/dist-packages/pbr/packaging.py", line 755, in get_version
    name=package_name))
    Exception: Versioning for this project requires either an sdist tarball, or access to an upstream git repository. It's also possible that there is a mismatch between the package name in setup.cfg and the argument given to pbr.version.VersionInfo. Project name python-seamicroclient was given, but was not able to be found.

With quilt push -a, no error.

However, with 0.4.0+2016.05.20.git.40ee44c664, I confirm your findings that it neither fails with or without the patches applied.

The reason for this is the new upstream version generates its own PKG-INFO file, which is essentially identical to the one we're patching in except it has a generic version number:

    Version: 0.0.1.dev10

With our patch in place, this file gets generated with the intended version. So while add-pkg-info.patch is no longer required for fixing a FTBS it's still necessary to get the right version into the egg packaging.