Code review comment for ~bryce/ubuntu/+source/python-seamicroclient:python-seamicroclient-merge-v0.4.0-3-eoan

Revision history for this message
Bryce Harrington (bryce) wrote :

I'm not sure why they called that out specifically in that changelog entry. Both python-mock and python-requests were already present in the 0.4.0-1 control file in Debian, for python2. I am not seeing any special reason why they would be mentioned, except perhaps in relation to the ubuntu-side python3 support; since that's being dropped with this merge I don't think the details of that work need carried forward.

Notice also that this changelog entry was indented under debian/patches, which is odd. Since there doesn't seem to be a distinct change associated with it, I am assuming it's misplaced, and was intended to go with the python3 support section.

« Back to merge proposal