Ubuntu
python-seamicroclient package

Code review comment for ~bryce/ubuntu/+source/python-seamicroclient:python-seamicroclient-merge-v0.4.0-3-eoan

  1. Git
  2. lp:~bryce/ubuntu/+source/python-seamicroclient
  3. python-seamicroclient-merge-v0.4.0-3-eoan
  4. Merge into debian/sid
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

I'm looking at the split tag, and I think you squashed two commits together that should be apart.

Specifically, this d/changelog entry:
        - debian/control: Depends on python3-mock and python3-requests.

is part of this commit:
commit 03f8b87d16ed315495fa84139c0ed49142208050 (HEAD, tag: bryce/split/0.4.0-1ubuntu1)
Author: Bryce Harrington <email address hidden>
Date: Thu Aug 1 14:44:58 2019 -0700

        - Add python3 support

Unless this is needed for python3 support, i.e., not just some extra build-deps that was missing also in py2. Then it's fine.

review: Needs Information

« Back to merge proposal