Code review comment for ~bryce/ubuntu/+source/php7.4:fix-lp1890263-focal
Revision history for this message
| Bryce Harrington (bryce) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> In the libapache2-
> Replaces version is not pointing to the exact version being shipped here?
> i.e., why ">> 7.4.3-4~" instead of ">> 7.4.3-4ubuntu2.
Yeah, this was a point I was really uncertain of so glad you brought it up. I followed the debian documentation, and looked at some similar packages on our side, but the precise Ubuntu policy wasn't clear. I wanted to make sure it doesn't fail if, e.g. someone had only -security and not -updates, or even if they had neither enabled. This seemed to work. Do you have more certainty that it should be ">> 7.4.3-4ubuntu2.
> Finally, I am wondering why this design differs from the one proposed in
> https:/
> where the transitional packages would only depend on the new package
> and the new package would replace/break the old ones.
Originally my hope had been to force dependence on the libapache2-mod-php package instead of the versioned package, but I could not get that to behave as I wished. The solution possibly could be simplified by omitting mention of libapache2-mod-php, which I believe would result in essentially what you describe? Including libapache2-mod-php seems to cause no harm, but it appears to get removed when the user does apt-get autoremove. Anyway, most definitely open to alternative suggestions.
Thanks for reviewing.