Ubuntu
php7.4 package

Code review comment for ~bryce/ubuntu/+source/php7.4:sru-lp1887826-curlfile-post-focal

  1. Git
  2. lp:~bryce/ubuntu/+source/php7.4
  3. sru-lp1887826-curlfile-post-focal
  4. Merge into ubuntu/focal-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog, Version, ... all look good to me.
The patches could use some headers again, but in this case one can recognize they are upstream patches and the hash is preserved, so I consider adding the headers optional.

I can recommend git-to-dquilt which does all that for you in one go.
https://git.launchpad.net/~ubuntu-server/ubuntu-helpers/tree/README.md#n63
but as I said optional in this case.

The patches are huge, give me a few minutes if they look SRU-compatible on closer examination.

« Back to merge proposal