Ubuntu
php7.4 package

Code review comment for ~bryce/ubuntu/+source/php7.4:fix-lp1850933-focal

  1. Git
  2. lp:~bryce/ubuntu/+source/php7.4
  3. fix-lp1850933-focal
  4. Merge into ubuntu/devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Quote: "Debian differs from Ubuntu here in that they try to support multiple php versions co-installed. So, it's unlikely this fix would be upstreamable."

That would have been the only thing I wanted to see, but I agree to the above.
The change itself LGTM to avoid a serious issues for upgraders to 20.04.

I'm glad that after PHP itself has migrated it is time for such fixes now.

This is based on my suggestion that was for 7.2 in Eoan.
But for Focal the solution has to be slightly different. Here the fix needs to consider two upgrade paths:
- from Eoan
- from Bionic
IMHO we need also to conflict with libapache2-mod-php7.2 (Bionics version) to fix both paths.

Do you agree?

review: Needs Fixing

« Back to merge proposal