Code review comment for ~bryce/ubuntu/+source/php-parser:sru-lp1895878-disable-tests

On Mon, Oct 19, 2020 at 9:47 PM Bryce Harrington <email address hidden>
wrote:

> Regarding armhf, I am able to reproduce most of these failures on my own
> amd64 machine, and an earlier test in a ppa showed they fail on other
> arch's as well. Honestly, all of these php test failures kind of bleed
> together in my memory at this point, and I can't recall precisely if this
> was one I definitely narrowed to just armhf, or if perhaps maybe it took
> longer to run than the others so lost a race against whatever other package
> caused the breakage. In any case, the tests definitely fail on more than
> just armhf currently, so conditionalizing on machine arch would not be a
> complete fix.
>

Ok then, thanks for the explanation!

As a side note, the original impetuous for this sru was to enable another
> php7.4 SRU to go through. But that php sru has now gone through (thanks to
> a CVE bumping it in). So, while the issue still exists here with
> php-parser, at least the near term pressure is off. Given that, do you
> think we should hold off until the failures can be more thoroughly
> diagnosed, or should we press ahead so that next time there's a php sru it
> doesn't bog down?
>

IMHO I'd continue to fix this as intended (neither stall, nor switch to
spend 5 more days).

> In either case, I'll incorporate your other suggested changes before
> backburnering or proceeding.
>

Ok, once those are in I think you are all set then - thanks for the
discussion.