Code review comment for ~bryce/ubuntu/+source/nginx:merge-v1.18.0-3

Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review Christian.

Fwiw, I had set up a previous PPA with all arch's enabled - which built find on all iirc, but then noticed something I needed to change, so I deleted the PPA and made a new one for this MP, but forgot to enable arches on this one.

I need to think more on the upgrade paths and on the Debian forwards, but the remaining changes I've incorporated in my local checkout; I'll re-push for review tomorrow.

Regarding the dropped bits, I have been trying to use andreas' approach to let git-ubuntu generate the changelog, so only put '* Dropped' on one commit, and put all the other drop commits following that. But you're right, this is confusing and error prone, and occurs to me is something git-ubuntu ought to be doing for us since it's within its power. I've redone my git tree to prefix the drop commits with this, and taken a task to add this feature to git-ubuntu.

« Back to merge proposal