Code review comment for ~bryce/ubuntu/+source/logwatch:logwatch-merge-v7.5.2-1-focal

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog:
- [√] old content and logical tag match as expected
- [√] changelog entry correct version and targeted codename
- [√] changelog entries correct
- [√] update-maintainer has been run (better than my take last time)

Actual changes:
- [√] no major upstream changes to consider (the systemd improvements seem good to have for 20.04)
- [-] no further upstream version to consider - there would be 7.5.3.
      Maybe not worth going ahead, but there are more systemd improvements to avoid false positives that would be great. Given how trivial the merge is maybe add a re-check right before FF is Debian has updated?
- [√] debian changes look safe

Old Delta:
- [√] dropped changes are ok to be dropped
- [√] nothing else to drop
- [√] changes forwarded upstream/debian (if appropriate)

New Delta:
- [√] no new patches added

Build/Test:
- [√] build is ok
- [√] sanity checks test fine

Overall +1 hoping for 7.5.3 to be re-mergeable in time

review: Approve

« Back to merge proposal