Code review comment for ~bryce/ubuntu/+source/heimdal:merge-v7.7.0adfsg-6-lunar

Revision history for this message
Robie Basak (racb) wrote :

lgtm

A couple of things of note:

1) I wondered if disabling lto was still needed. This would need build testing with lto on amd64 and i386 and then comparing the resulting dependencies. And I wonder if we need a more general view to dealing with the situation that lto results in that issue arising. But the changes from last time aren't significant and none look like they would affect that issue, so it's probably not worth checking until we get significant changes from upstream, or some change that looks like it might fix the issue. It does seem like a bit of a hack to disable lto though.

2) I was puzzled by previous changelog entry changes until I realised that the Debian maintainer fixed historical typos. I guess it makes sense to follow in Ubuntu.

review: Approve

« Back to merge proposal