Code review comment for ~bryce/ubuntu/+source/fetchmail:fix-2035-hirsute
Revision history for this message
| Bryce Harrington (bryce) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> TBH I am not sure if we will benefit from the "make check" test
> considering autopkgtest is more about testing the installed
> version of the package. Which kind of issue we could spot with it?
My thought process here was that running the upstream testsuite is a standard practice for inclusion in autopkgtests. fetchmail has a handful of test cases, triggered by running make check, via Perl's standard testing tooling:
PASS: t.smoke
SKIP: t.validate-xhtml10
SKIP: t.validate-xhtml
PASS: t.x509_name_match
PASS: t.realpath
PASS: t.tls-aux
Admittedly, these test cases are super trivial, which is why I went ahead with creating the POP3 test. But, perhaps future development will add more tests, and in any case they seemed to pass (for me), so figured it couldn't hurt to hook them up. It doesn't look like 'make check' is triggered during the fetchmail build process, so to me it seemed appropriate to do in a DEP8.