Code review comment for ~bryce/ubuntu/+source/fetchmail:fix-2035-hirsute

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

TBH I am not sure if we will benefit from the "make check" test considering autopkgtest is more about testing the installed version of the package. Which kind of issue we could spot with it?

About the "set -x" in the operation test, what happens is what Sergio mentioned, the commands will be printed to stderr by default. We have three options here:

1) Do nothing and leave it as-is, without printing the commands;
2) Add the allow-stderr restriction as Utkarsh mentioned above;
3) Add "exec 2>&1" to the top of the shell script to pipe everything to stdout.

I'd go with option 3 (I have done that in some of my packages in Debian), but feel free to pick whatever you think makes more sense to you.

« Back to merge proposal